[FFmpeg-devel] [PATCH] mingw memalign hack fix

Michael Niedermayer michaelni
Thu Nov 27 01:06:44 CET 2008

On Wed, Nov 26, 2008 at 03:54:56PM -0800, David DeHaven wrote:
>>> +    diff = ((-(long)ptr - 1)&15) + 1;
>> intptr_t should be used instead of long.
> Agreed. I fixed av_malloc too...

still exploitable, besides your code cannot work at all
when "diff" changes the content of the buffer will not be where realign()
requires it to be.

may i suggest that you first tell us which av_realloc() call is causig
problems, it likely should just be replaced by av_free() av_malloc()

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081127/9610e205/attachment.pgp>

More information about the ffmpeg-devel mailing list