[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

Ronald S. Bultje rsbultje
Thu Nov 27 03:41:52 CET 2008


Hi,

On Wed, Nov 26, 2008 at 6:40 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Nov 23, 2008 at 11:16:19AM -0500, Ronald S. Bultje wrote:
>> --- ffmpeg-svn.orig/libavformat/rdt.h 2008-11-18 20:24:07.000000000 -0500
>> +++ ffmpeg-svn/libavformat/rdt.h      2008-11-23 09:52:23.000000000 -0500
>> @@ -28,7 +28,7 @@
>>
>>  typedef struct RDTDemuxContext RDTDemuxContext;
>>
>> -RDTDemuxContext *ff_rdt_parse_open(AVFormatContext *ic, AVStream *st,
>> +RDTDemuxContext *ff_rdt_parse_open(AVFormatContext *ic, int first_stream_index,
>>                                     void *priv_data,
>>                                     RTPDynamicProtocolHandler *handler);
>
> first?
> first is 0, yes iam dumb :)
> but seriously, i dont think its clear to the reader what first_stream_index
> really is.

"Stream" is the term you suggested. :-).

> anyway IMHO the function needs some documentation anyway ...

Will do... If you understand, with some imagination, what
first_stream_index is, is the rest of the patch OK?

Ronald




More information about the ffmpeg-devel mailing list