[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

Ronald S. Bultje rsbultje
Fri Oct 3 14:59:58 CEST 2008

Hi Luca,

On Wed, Oct 1, 2008 at 1:17 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
>> So, rtsp.c currently hardcodes RTPDemuxContext. My patches allow RDT
>> to be used in addition to RTP, and LucaA asked to not use the RTP API
>> in these cases. Therefore, we split it in such a way that RDT uses
>> rdt_*() and RDT* API, while RTP uses rtp_*() and RTP* API. rtsp.c then
>> decides which one to call based on the chosen transport protocol
>> during the SETUP.
>> This change means RTSP may serve either RTP or RDT, and thus we
>> shouldn't hardcode the type of structure of the "transport context",
>> or rtp_ctx. This patch makes that type opaque in rtsp.c. This is not a
>> problem, since rtsp.c never accesses any members of that struct,
>> except for one case (see below).
> Hmm then probably you should first make opaque also the name of the field.

So attached are two patches to do this.

One (rtsp-set_dynamic_protocol.patch) implements a function so that
rtsp.c does not access members of RTPDemuxContext anymore, this is a
prerequisite for making it opaque.

Number 2 (rtsp-opaque-tx_ctx.patch) implements opaqueing of the struct
RTPDemuxContext in rtsp.c, and renaming of the field (as suggested) to
tx_ctx and cur_tx (tx is short for transport).

Patch number 3 implements RDTDemuxContext and will come in a next email.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtsp-set_dynamic_protocol.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081003/8548a4e9/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtsp-opaque-tx_ctx.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081003/8548a4e9/attachment.asc>

More information about the ffmpeg-devel mailing list