[FFmpeg-devel] [PATCH] QCELP decoder
Fri Oct 3 18:52:53 CEST 2008
M, Kenan Gillet <kenan.gillet at gmail.com> wrote:
> On Oct 2, 2008, at 2:25 PM, Vitor Sessak wrote:
> For codecs that were supposed to be converted to signed 16-bit at some
> point should be indeed between -1. and 1.. A good way to test if did not
> do something wrong is to decode a sample to wav and see if your change
> changes the result. It should either don't change or change a negligible
> amount (see tests/tiny_psnr for evaluating how much it has changed).
> From the samples,
> tiny_psnr gives:
> stddev: 0.00 PSNR:999.99 bytes: 250284/ 250284
> For blue_earth.mov,tiny_psnr gives:
> stddev: 119.57 PSNR: 6.57 bytes: 19681324/ 19681324
> For h263.mov, tiny_psnr gives:
> stddev: 73.51 PSNR: 10.79 bytes: 13511404/ 13511404
> is it still ok, or is something wrong?
of course, something was wrong.
After corrected a bug,
the new values for this 2 files are:
blue_earth.mov: stddev: 2.51 PSNR: 40.11 bytes: 19681324/ 19681324
h263.mov : stddev: 1.81 PSNR: 42.95 bytes: 13511404/ 13511404
is it now acceptable?
if yes, i will post an updated patch.
More information about the ffmpeg-devel