[FFmpeg-devel] [PATCH] fix check in dyn_buf_write that gcc 4.3 optimizes away

Michael Niedermayer michaelni
Sat Oct 4 23:52:48 CEST 2008


On Sat, Oct 04, 2008 at 11:28:08PM +0200, Reimar D?ffinger wrote:
> On Sat, Oct 04, 2008 at 10:52:59PM +0200, Michael Niedermayer wrote:
> > On Sat, Oct 04, 2008 at 10:02:35PM +0200, Reimar D?ffinger wrote:
> > >  Btw. with function also has a weird "return -1234;" that
> > > looks a lot like nonsense to me...
> > 
> > well, it looks like nonsense to me too :)
> 
> Maybe someone can clean the whole file up a bit?

thank you for volunteering, this is very much appreciated :))))


> Attached patch touches some places I found particularly weird/ugly,
> I did not even test compilation though.

well it would look ok if it where split cleanly and had been tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081004/d9782c17/attachment.pgp>



More information about the ffmpeg-devel mailing list