[FFmpeg-devel] [PATCH] fix check in dyn_buf_write that gcc 4.3 optimizes away

[Reimar Döffinger]

On Sat, Oct 04, 2008 at 11:52:48PM +0200, Michael Niedermayer wrote:
> On Sat, Oct 04, 2008 at 11:28:08PM +0200, Reimar D?ffinger wrote:
> > On Sat, Oct 04, 2008 at 10:52:59PM +0200, Michael Niedermayer wrote:
> > > On Sat, Oct 04, 2008 at 10:02:35PM +0200, Reimar D?ffinger wrote:
> > > >  Btw. with function also has a weird "return -1234;" that
> > > > looks a lot like nonsense to me...
> > > 
> > > well, it looks like nonsense to me too :)
> > 
> > Maybe someone can clean the whole file up a bit?
> 
> thank you for volunteering, this is very much appreciated :))))

To my dismay it is not the only half-finished/unapplied cleanup patch I
have lying around, so if you wait for me it might take quite some
time...

> > Attached patch touches some places I found particularly weird/ugly,
> > I did not even test compilation though.
> 
> well it would look ok if it where split cleanly and had been tested

I do not even know what uses that code and thus not how to really test
it...
Testing compilation and make test alone is not a big problem though
(neither is splitting once I un-mess my git tree..).