[FFmpeg-devel] [PATCH] Set systems that should support DOS paths in configure

Ramiro Polla ramiro.polla
Mon Oct 6 18:42:06 CEST 2008


Hi,

On Fri, Oct 3, 2008 at 7:58 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
> "Ramiro Polla" <ramiro.polla at gmail.com> writes:
>> $subj
[...]
>> Index: libavformat/os_support.h
>> ===================================================================
>> --- libavformat/os_support.h  (revision 15464)
>> +++ libavformat/os_support.h  (working copy)
>> @@ -35,6 +35,12 @@
>>  #  define lseek(f,p,w) _lseeki64((f), (p), (w))
>>  #endif
>>
>> +#ifdef HAVE_DOS_PATHS
>> +    #define is_dos_path(path) (path[1]==':')
>
> This allows anything as the "drive letter", though maybe that's
> considered OK.

According to [0], only letters are allowed for the drive letter
(altough I've seen some program, fsdext2 IIRC, using numbers). Added
isalpha() for path[0].

>> +#else
>> +    #define is_dos_path(path) (0)
>
> Useless ().

Removed.

Also changed from #define to static inline int like ff_network_init().

Ramiro Polla
[0] http://msdn.microsoft.com/en-us/library/cc232152.aspx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dospaths_6.diff
Type: text/x-diff
Size: 2578 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081006/9635ad49/attachment.diff>



More information about the ffmpeg-devel mailing list