[FFmpeg-devel] [PATCH] Support absolute DOS paths for presets.

[Måns Rullgård]

"Ramiro Polla" <ramiro.polla at gmail.com> writes:

> On Fri, Oct 10, 2008 at 2:55 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
>> "Ramiro Polla" <ramiro.polla at gmail.com> writes:
>>
>>> Index: ffmpeg.c
>>> ===================================================================
>>> --- ffmpeg.c  (revision 15593)
>>> +++ ffmpeg.c  (working copy)
>>> @@ -3685,7 +3685,7 @@
>>>              f= fopen(tmp, "r");
>>>          }
>>>      }
>>> -    if(!f && ((arg[0]=='.' && arg[1]=='/') || arg[0]=='/')){
>>> +    if(!f && ((arg[0]=='.' && arg[1]=='/') || arg[0]=='/' || is_dos_path(arg))){
>>
>> Please break that line, preferably after the last ||.
>>
>> --
>> M?ns Rullg?rd
>> mans at mansr.com
>
>>
>
> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 15593)
> +++ ffmpeg.c	(working copy)
> @@ -3685,7 +3685,8 @@
>              f= fopen(tmp, "r");
>          }
>      }
> -    if(!f && ((arg[0]=='.' && arg[1]=='/') || arg[0]=='/')){
> +    if(!f && ((arg[0]=='.' && arg[1]=='/') || arg[0]=='/' ||
> +        is_dos_path(arg))){

I'd prefer the second line indented like this:

+    if(!f && ((arg[0]=='.' && arg[1]=='/') || arg[0]=='/' ||
+              is_dos_path(arg))){

This also happens to be how Emacs wants it to be.

-- 
M?ns Rullg?rd
mans at mansr.com