[FFmpeg-devel] [PATCH 4/4] Include headers for optional libraries only when enabled.

[Aurelien Jacobs]

On Sun, 12 Oct 2008 17:52:51 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Thu, Oct 02, 2008 at 09:26:03PM +0200, Aurelien Jacobs wrote:
> > Diego Biurrun wrote:
> > 
> > > On Thu, Oct 02, 2008 at 06:55:19PM +0200, Diego 'Flameeyes' Petten? wrote:
> > > > Include the headers for libavfilter, libswscale and libpostproc when
> > > > they are enabled (and thus linked in).
> > > > 
> > > > --- a/cmdutils.c
> > > > +++ b/cmdutils.c
> > > > @@ -26,10 +26,16 @@
> > > >  
> > > > +#if ENABLE_AVFILTER
> > > 
> > > You should use CONFIG_ definitions in preprocessor checks.
> > 
> > Why ?
> 
> Consistency.

This file already contains some #if ENABLE_*, and it is shorter
than #ifdef CONFIG_*.

> We do have two different definitions, it was my impression
> that they should be used for different purposes.

Maybe we should try to reduce usage of the useless one
(ie. CONFIG_*), with a final goal being totally removing one
of the two definitions ?
That would slightly simplify the code, overall.

Aurel