[FFmpeg-devel] [PATCH]Enable ac3 decoding regression test (improved PSNR)

Michael Niedermayer michaelni
Tue Oct 14 18:43:39 CEST 2008

On Tue, Oct 14, 2008 at 03:05:24PM +0000, Carl Eugen Hoyos wrote:
> Hi!
> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> > > > Attached is a patch to enable ac3 decoding regression tests. I found the 
> > > > best values for stddec and PSNR with the following command line:
> > > > tiny_psnr data/ac3.vsynth.out.wav data/vsynth.ref.wav 2 1024
> > > >
> > > > Please comment, Carl Eugen
> > > 
> > > patch looks ok
> > 
> > Patch applied, Carl Eugen
> As can be seen on FATE, http://fate.multimedia.cx/index.php?build_record=33798
> this patch broke regression tests with gcc 2.95.3.
> I think the patch should not be reverted, because it shows that ffmpeg decodes
> AC-3 (slightly) different when compiled with gcc 2.95.3.

I disagree, Developers have to be able to
update the checksums when they change due to changes in the code. When they
dont work on some platform devels are unable to update the checksums on that
Also the tests are there to catch bugs if they fail already then new
bugs are obscured, thats especially true because the later tests arent
run when earlier ones fail.

The correct place for "AC-3 decodes differently on gcc 2.95" is roundup.

Once the regression test works on 2.95 it can be enabled again.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081014/9b58f17f/attachment.pgp>

More information about the ffmpeg-devel mailing list