[FFmpeg-devel] [PATCH] fix libavdevice/audio.c build on FreeBSD

Alexis Ballier alexis.ballier
Sun Oct 19 14:56:34 CEST 2008


> Does any system with OSS audio not have sys/select.h?  Until we find
> one, I'd drop the #ifdef.

well, according to:
http://opengroup.org/onlinepubs/007908799/xsh/select.html
single unix spec v2 doesn't require sys/select.h

but this one requires sys/select.h:
http://www.opengroup.org/onlinepubs/009695399/functions/select.html

Since you probably know better than me what ffmpeg requires, here is a
patch without #ifery, leaving the decision up to you. I think ffmpeg
requires IEEE 1003.1-2004 so we may assume sys/select.h is here and
the #ifery seems to have been added for mingw compat where oss isn't
supported, thus I believe it's indeed sane to drop the #ifdef.

Alexis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: selectnoifdef.patch
Type: application/octet-stream
Size: 347 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081019/40e3a3ee/attachment.obj>



More information about the ffmpeg-devel mailing list