[FFmpeg-devel] [PATCH] QCELP decoder
Thu Oct 30 22:31:23 CET 2008
On Thu, Oct 30, 2008 at 10:07:45PM +0100, Vitor Sessak wrote:
> Michael Niedermayer wrote:
> > On Tue, Oct 28, 2008 at 04:47:02PM -0700, Kenan Gillet wrote:
> > [..]
> > ok
Please cut down on your quotes a bit, thanks.
> > ok
> Should I add a qcelpdec.c file and commit this?
There are precedents, so do it.
> >> --- libavcodec/celp_filters.h (revision 15692)
> >> +++ libavcodec/celp_filters.h (working copy)
> >> @@ -69,4 +69,28 @@
> >> +/**
> >> + * LP synthesis filter.
> >> + * @param out [out] pointer to output buffer
> >> + * - the array out[-filter_length, -1] must
> >> + * contain the previous result of this filter
> >> + * @param filter_coeffs filter coefficients.
> >> + * @param in input signal
> >> + * @param buffer_length amount of data to process
> >> + * @param filter_length filter length (10 for 10th order LP filter)
> >> + *
> >> + * @return 1 if overflow occurred, 0 - otherwise
> > hmm void == 1 || 0 ?
> Oops, commited by error, should I revert?
I'd say commit the fix when it appears, there is no point in reverting
(currently) unused code.
More information about the ffmpeg-devel