[FFmpeg-devel] Brainfart cropping

Michael Niedermayer michaelni
Wed Sep 10 21:31:51 CEST 2008

On Wed, Sep 10, 2008 at 11:45:27AM -0700, Jason Garrett-Glaser wrote:
> For a while, I've dealt with tons of people complaining about the
> message "brainfart cropping not supported."  I figured this implied
> that the crop was >= the normal crop amount (>= one MB in size,
> 16x16), but the code itself puts the threshold at >=8.  This makes no
> sense, since this means that the vast majority of encoding resolutions
> will result in such a message being printed by ffmpeg!
> if(sps->crop_right >= 8 || sps->crop_bottom >= (8>>
> !h->sps.frame_mbs_only_flag)){
>             av_log(h->s.avctx, AV_LOG_ERROR, "brainfart cropping not
> supported, this could look slightly wrong ...\n");
>         }
> Are we sure that this is right?

the crop values are AFAIK in chroma samples, so 8 should be correct for 4:2:0
But it should be easy to check with the reference sw how much is cropped.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080910/3c56de59/attachment.pgp>

More information about the ffmpeg-devel mailing list