[FFmpeg-devel] [PATCH] Move VC1 loop filter to DSPContext

Michael Niedermayer michaelni
Wed Apr 1 22:00:34 CEST 2009


On Wed, Apr 01, 2009 at 02:44:13PM -0400, David Conrad wrote:
> On Apr 1, 2009, at 1:37 PM, Michael Niedermayer wrote:
>
>> On Wed, Apr 01, 2009 at 04:23:26AM -0400, David Conrad wrote:
>>> Hi,
>>>
>>> First patch moves VC1's loop filter function as is to DSPContext, the
>>> second splits it according h/v and size for faster/easier simd
>>> implementations.
>>>
>>> Since these functions require 16 bit arithmetic, there isn't really a 
>>> speed
>>> advantage to having size 16 functions in simd. I kept them for 
>>> consistency
>>> and because it's a bit uglier to use size 8 x2 in vc1_loop_filter_iblk.
>>
>> The changes to files maintained by me are ok, assuming it has been 
>> verified
>> that the vc1 loop filter is bitexact relative to the binary codec
>> (i would not want incorrect code to be optimized)
>
> The loop filter is identical to the VC1 spec and the one in the reference 
> implementation.
> The file I have that uses the loop filter is bitexact to the binary codec 
> for I and P frames, but not B frames.

kostya? what is wrong with the B frames?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090401/64232e0b/attachment.pgp>



More information about the ffmpeg-devel mailing list