[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Olivier Guilyardi]

Attached: jack demuxer 0.15

Diego Biurrun wrote:
> On Thu, Apr 02, 2009 at 12:36:16PM +0200, Olivier Guilyardi wrote:
>> Attached:
>> - jack demuxer patch 0.14
>> - av_fifo_space patch
>>
>> --- configure	(revision 18313)
>> +++ configure	(working copy)
>> --- doc/general.texi	(revision 18313)
>> +++ doc/general.texi	(working copy)
> 
> OK
> 
>> --- libavformat/Makefile	(revision 18313)
>> +++ libavformat/Makefile	(working copy)
>> @@ -243,6 +243,9 @@
>>  
>> +# libavdevice dependencies
>> +OBJS-$(CONFIG_JACK_DEMUXER)              += timefilter.o
> 
> I have to keep asking: Why isn't timefilter.c in libavdevice to begin
> with?

Michael has already answered this:
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-March/065114.html

>> --- libavdevice/jack_audio.c	(revision 0)
>> +++ libavdevice/jack_audio.c	(revision 0)
>> @@ -0,0 +1,327 @@
>> +        for (j = 0; j < self->buffer_size; j++) {
>> +            pkt_data[j * self->nports + i] = buffer[j];
>> +        }
> 
> useless {}

Removed

> 
>> +        if (!self->client) {
>> +            av_log(context, AV_LOG_ERROR, "Input error: JACK server is gone\n");
>> +        }
> 
> ditto

Fixed

-- 
  Olivier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-r18316-jack-0.15.patch
Type: text/x-patch
Size: 14024 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090402/7b7364a1/attachment.bin>