[FFmpeg-devel] [PATCH] libavfilter-soc: sws cpu caps flags detection

Michael Niedermayer michaelni
Fri Apr 3 00:22:12 CEST 2009


On Fri, Apr 03, 2009 at 12:06:05AM +0200, Stefano Sabatini wrote:
> On date Thursday 2009-04-02 23:06:22 +0200, Michael Niedermayer encoded:
> > On Thu, Apr 02, 2009 at 10:49:18PM +0200, Stefano Sabatini wrote:
> > > On date Wednesday 2009-04-01 22:40:21 +0200, Michael Niedermayer encoded:
> > > > On Wed, Apr 01, 2009 at 09:47:10PM +0200, Stefano Sabatini wrote:
> > > > > Hi all,
> > > > > 
> > > > > as in subject.
> > > > > 
> > > > > BTW SWS_CPU_CAPS_MMX2 and SWS_CPU_CAPS_BFIN are not used, since I
> > > > > don't know how to map them to corresponding FF_MM_* flags.
> > > > 
> > > > FF_MM_MMXEXT
> > > 
> > > Updated, I also suggest to rename SWS_CPU_CAPS_MMX2 ->
> > > SWS_CPU_CAPS_MMXEXT for consistency with lavc 
> > 
> > > (or the other way if you
> > > prefer).
> > 
> > i do and the cpu caps should be merged so they match with the next major bump
> > and dont need this remappingf anymore
> 
> Thus I suggest to move them to lavu, maybe togheter with all the CPU
> detection stuff.

lavu is supposed to be a small lightweight lib that contains ONLY
things that are usefull for a wide range of applications.

Every time someone suggests to move something into lavu without ANY
argument that honestly feels like a punch to the face.


> 
> > [...]
> > > @@ -66,6 +77,11 @@
> > >          }
> > >      }
> > >  
> > > +    {
> > > +        int sws_flags = av_get_int(scale->sws, "sws_flags", NULL);
> > > +        av_set_int(scale->sws, "sws_flags", sws_flags + get_sws_cpu_caps_flags());
> > > +    }
> > > +
> > >      /* sanity check parms */
> > >      if(scale->w <  -1 || scale->h <  -1)
> > >          return -1;
> > 
> > can the user still override it ?
> 
> No,

so its broken
default should be detection but the user should be able to force them
disabled

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090403/d83c5f5c/attachment.pgp>



More information about the ffmpeg-devel mailing list