[FFmpeg-devel] Google Summer of Code participation

Michael Niedermayer michaelni
Sat Apr 4 00:06:57 CEST 2009


On Fri, Apr 03, 2009 at 07:13:10PM +0200, Thilo Borgmann wrote:
>
>
> Michael Niedermayer schrieb:
>> ff_h263_decode_frame2 ?
>>   
> Oh, there were troubles with some files containing more than one AVCodec 
> struct, did not recognized them all...
>
>> have you even tried to compile this?
>>
>> please make sure make && make test works before submitting patches
>>
>>   
> Something weird drove me to mail that, I apologize to you for wasting your 
> time!
>
> Ok, revision 2 attached freed of these mistakes and compiles well. I'm not 
> 100% sure that the 'make test' succeeded, as there are some lines of output 
> at the end indicating some issues. As far as I can see, none of them shall 
> be caused by me. To be sure about that, I also attached the last few line 
> of the test run.
>
> I hope it will be worth reviewing this time.
> TB

[...]
> @@ -3056,6 +3055,10 @@ int avcodec_decode_audio2(AVCodecContext *avctx, int16_t *samples,
>                           int *frame_size_ptr,
>                           const uint8_t *buf, int buf_size);
>  
> +int avcodec_decode_audio3(AVCodecContext *avctx, int16_t *samples,
> +                         int *frame_size_ptr,
> +                         AVPacket *avpkt);
> +
>  /**
>   * Decodes a video frame from \p buf into \p picture.
>   * The avcodec_decode_video() function decodes a video frame from the input

missing documentation,all public functions must be documentated

[...]
> @@ -680,15 +682,6 @@ static int ipvideo_decode_frame(AVCodecContext *avctx,
>      return buf_size;
>  }
>  
> -static int ipvideo_decode_frame2(AVCodecContext *avctx,
> -                        void *data, int *data_size,
> -                        AVPacket *avpkt)
> -{
> -    return ipvideo_decode_frame(avctx, data, data_size, avpkt->data, avpkt->size);
> -}
> -
> -
> -
>  
>  static av_cold int ipvideo_decode_end(AVCodecContext *avctx)
>  {

that looks like it is not against svn

[...]

> @@ -334,7 +335,6 @@ static int decode_frame(AVCodecContext * avctx, void *data, int *data_size, cons
>  }
>  
>  
> -
>  /*
>   * Init kmvc decoder
>   */

cosmetic

[...]
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index 4113382..d930302 100644
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -530,12 +530,25 @@ int attribute_align_arg avcodec_decode_video(AVCodecContext *avctx, AVFrame *pic
>  {
>      int ret;
>  
> +    AVPacket avpkt;
> +    avpkt.data = buf;
> +    avpkt.size = buf_size;
> +
> +	return avcodec_decode_video2(avctx, picture, got_picture_ptr, &avpkt);

tabs


[...]
> index 3a90194..ec287b1 100644
> --- a/libavcodec/vp56.h
> +++ b/libavcodec/vp56.h
> @@ -173,6 +173,8 @@ int vp56_free(AVCodecContext *avctx);
>  void vp56_init_dequant(VP56Context *s, int quantizer);
>  int vp56_decode_frame(AVCodecContext *avctx, void *data, int *data_size,
>                        const uint8_t *buf, int buf_size);
> +int vp56_decode_frame2(AVCodecContext *avctx, void *data, int *data_size,
> +                      AVPacket *avpkt);
>  
>  
>  /**

hmm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090404/87dab9bd/attachment.pgp>



More information about the ffmpeg-devel mailing list