[FFmpeg-devel] [PATCH] als in mp4

[Jai Menon]

On Fri, Apr 3, 2009 at 11:28 PM, Baptiste Coudurier
<baptiste.coudurier at gmail.com> wrote:
> Hi Jai,
>
> On 4/3/2009 3:00 AM, Jai Menon wrote:
>> On 3/23/09, Baptiste Coudurier <baptiste.coudurier at gmail.com> wrote:
>>> Jai Menon wrote:
>>> ?> On 3/23/09, Baptiste Coudurier <baptiste.coudurier at gmail.com> wrote:
>>> ?>> Jai Menon wrote:
>>> ?>> ?>> [...]
>>> ?>>
>>> ?>> ?>>
>>> ?>> ?>> When were they initially set to the correct values?
>>> ?>> ?>
>>> ?>> ?> stsd atom/box? i think
>>> ?>> ?>
>>> ?>>
>>> ?>>
>>> ?>> Hummm, stsd does not contain the correct sample number for everything
>>> ?>> ?using 'mp4a' tag. Values are correct in 'esds' box.
>>> ?>
>>> ?> Which means we should parse the extradata (in this case als specific
>>> ?> conf) and get values from there? I can do this for als by maybe adding
>>> ?> a new function to mpeg4audio.c.
>>>
>>>
>>> I don't know how exactly ALS works, but it might use the
>>> ?AudioSpecificConfig like others, this code might belong to mpeg4audio.c,
>>> ?yes.
>>
>> So hows attached patch?
>>
>
> I think the AOT_ALS case should be handled within mpeg4audio_get_config,
> to retrieve correct sample_rate/channels if these are not set in
> AudioSpecificCOnfig, I also beleve all AOT should be handled this way.

another attempt.

-- 
Regards,

Jai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-mp4als-codec-id-and-bump-minor.patch
Type: text/x-patch
Size: 906 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090406/4ad2c23e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-hook-up-als-aot-to-its-codec-id.patch
Type: text/x-patch
Size: 717 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090406/4ad2c23e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-parse-stream-parameters-from-als-specific-config.patch
Type: text/x-patch
Size: 3098 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090406/4ad2c23e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-cosmetics-reindent-after-last-commit.patch
Type: text/x-patch
Size: 1184 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090406/4ad2c23e/attachment-0003.bin>