[FFmpeg-devel] [PATCH] QCELP decoder postfilter & final gain control

[Kenan Gillet]

Hi Reynaldo,
On Apr 6, 2009, at 6:54 PM, Reynaldo H. Verdejo Pinochet wrote:

> Hi Kenan
>
> Kenan Gillet wrote:
>>
>> - patches 1, 2 and 3 are splitting and cleanup the current code.
>
> I'd reject patch 2 out of it not providing any real advantage. The
> first mult (0*40) (all even?) should get optimized out anyway and
> we would end up adding a final 'rewind' that it's not needed with
> the current code.
>
> Maybe someone can correct me if I'm wrong?

patch #2 works with #3, the 'rewind' disappears in #3.
i tried to split #2 and #3, maybe i should not have ?

Kenan