[FFmpeg-devel] [PATCH] fix speex sample

[Baptiste Coudurier]

On 4/8/2009 3:46 PM, Michael Niedermayer wrote:
> On Wed, Apr 08, 2009 at 02:49:44PM -0700, Baptiste Coudurier wrote:
>> On 4/8/2009 2:28 PM, Michael Niedermayer wrote:
> [...]
>>> I can fix some and i will certainly not concentrate on ones that other
>>> developers have a lot of interrest in and are capable to fix
>>> because such bugs alraedy have people who will eventually fix them
>> So this means basically I can stop concentrate on _any_ bug since you
>> are capable of fixing them ;)
> 
>>> if someone submits a patch, the maintainer reviews it
>>> its the same with patches from you to code maintained by me as it is
>>> with patches by me to code maintained by you or mans.
>>> IIRC you didnt fix every issue reimar pointed out in mp4/mov either.
>> Which ones ? AFAIK all isssues has been adressed except maybe the
>> complete edit list support which is non trivial at _all_, but I applied
>> somehow acceptable fix myself _based_ on Reimar patch. I just did not
>> refuse it, and I based my efforts on his work, assuming my maintainer role.
> 
> what about binary codecs in mplayer with lavf or subtitles? i dont remember
> exactly but i think there where some problems ...

This would more mplayer related issue, but yes I'm interested in it, but
it would require _exporting_ whole stsd, and this requires the stsd
patch first, then we must find an API to export whole stsd.

Or you can recreate 'stsd' in demux_lavf.c but this might not be exact
if you miss some atoms (fiel, pasp, clap, etc...), and in this case it's
more demux_lavf.c maintainer problem I'd say.

I don't know these subtitles problems. I tested some files, it seems to
work here.

>> The multiple stsd feature is implemented, and I submited a patch, it
>> depends on one seeking fix in aviobuf.c, for which I also sent a patch.
>>
>> Not mentioning that it takes me approximately 1 day to address issues on
>> roundup relative to mov/mp4. Btw you are listed as maintainer for mov as
>> well ;)
>>
>> This is effectively a different kind of maintainership.
> 
> it is not, you can look at avidec/enc and its also pretty bug free, or
> msmpeg4 or the mpeg1/2 decoder ...

msmpeg4 that should be true.

Mpeg2 decoder has an important bug IMHO since some time. I reported it,
and libmpeg2 does not have this bug and decodes correctly the first 2
frames. I lack some knowledge of the surrounding code, but I tried to
work on it at least. It should not take you much time to figure out the
problem I guess.

Avi demuxer had a bug I fixed recently. I should have wait a few months,
damn ;)

> flv is a little worse but not much
> and then there is mpeg-ts & ffserver for which i belive you are maintainer
> now, they are not even remotely close to bugfree not even close to flvdecs
> bugfreeness.

AFAIK I'm not official maintainer of mpeg-ts, but I don't mind being
maintainer and fixing bugs.

FFserver is certainly not bug free, however all roundup issue were
closed and fixed AFAIK, and it's working quite ok for me.

Now there is H.264 case which has 4 important/crash bugs in roundup.
Snow two.

>>>> but that's all right
>>>> with me. Let's wait a few months ;)
>>> you dont need to wait a few month before you fix your patch ;)
>> Well, like you said pretty well, I can spend my time on something else
>> than something maintainer is able to fix ;)
>> I don't have problem with this file personally, someone submited this
>> file. I just don't like bugs.
>>
>> If I were maintainer, I would have fixed it already, that's the whole
>> point. I would even have addressed your comments on -cvslog and changed
>> my original commit ;)
> 
> well, but you are not maintainer, and you will not become maintainer either
> if that prevents you from fixing flvdec, thats a pitty, cant be helped i
> guess.

Yes it can be helped, and you know it.

But that's no problem for me, it's just that I will have hard time
excusing you for refusing to let it go while you keep saying you don't
have time for it.

You just cannot reasonably refuse to share maintainership and say that
you don't have time to do it.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org