[FFmpeg-devel] Google Summer of Code participation

Michael Niedermayer michaelni
Thu Apr 9 04:56:25 CEST 2009


On Thu, Apr 09, 2009 at 03:25:10AM +0200, Thilo Borgmann wrote:
>
>
> Michael Niedermayer schrieb:
[...]
>>> +            int offset = 0;
>>> +            uint8_t *pd = s->image_buf;
>>> +            uint8_t *pd_last = s->last_image_buf;
>>> +
>>> +            for(j=0; j < s->height; j++) {
>>>     
>>
>>   
>>> +                for(i=0; i < s->image_linesize; i++) {
>>>     
>>
>> width
>>
>>   
> No. image_linesize != width. Linesize is needed here as the copy is done 
> byte-wise. But there are s->height of these long lines.

we want to just change width pixels not linesize samples.


[...]
>>   
>>> +        memcpy(s->last_image_buf, s->image_buf, s->image_linesize * 
>>> s->height);
>>>     
>>
>> memcpy should not be needed for decoding
>>   
> Hmm to avoid this call I think about double buffering via a second AVFrame 
> in the PNGContext instead of a uint8_t buffer? If you agree I will do this 
> tomorrow.

yes, that was my thought as well

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090409/ae20096b/attachment.pgp>



More information about the ffmpeg-devel mailing list