[FFmpeg-devel] [PATCH] lzo build system checks

[Reimar Döffinger]

On Thu, Apr 09, 2009 at 03:08:20PM +0200, Diego Biurrun wrote:
> On Thu, Apr 09, 2009 at 02:58:05PM +0200, Reimar D?ffinger wrote:
> > On Thu, Apr 09, 2009 at 02:38:11PM +0200, Diego Biurrun wrote:
> > > Here is a patch to properly hook up the lzo test in our build system.
> > > Reimar, maybe you can comment whether or not the different lzo functions
> > > are still really needed...
> > 
> > Wtf? Why would you want to make the lzo test test the libzo
> > decompression that FFmpeg doesn't even use at all?
> 
> You misinterpreted the intention of my patch.  I want it to be
> automatically included in 'make testprogs' if the required headers are
> present on the system.

liblzo is not required to test our lzo implementation.

> > And no you may not remove the libzo support from the test program, it is
> > there to allow speed comparison.
> > Probably the issue you have is the include?
> > Then put it under
> > #if defined(LIBLZO) || defined(LIBLZO_UNSAFE)
> 
> What is the program supposed to test by default?  Right now it prefers
> the library functions over the native ones.

No it doesn't, why do you think so? Nothing defines LIBLZO.