[FFmpeg-devel] [PATCH] Document ff_put_string()

Diego Biurrun diego
Sat Apr 11 15:57:37 CEST 2009


On Sat, Apr 11, 2009 at 03:53:48PM +0200, Stefano Sabatini wrote:
> On date Saturday 2009-04-11 15:45:58 +0200, Diego Biurrun encoded:
> > On Sat, Apr 11, 2009 at 03:37:57PM +0200, Stefano Sabatini wrote:
> > > --- ffmpeg.orig/libavcodec/bitstream.h	2009-04-11 15:19:16.000000000 +0200
> > > +++ ffmpeg/libavcodec/bitstream.h	2009-04-11 15:32:50.000000000 +0200
> > > @@ -160,6 +160,13 @@
> > > +
> > > +/**
> > > + * Puts the string \p s in the bitstream.
> > > + *
> > > + * @param put_zero if it is different from zero puts in the bitstream
> > > + * a '\0' char just after the end of the string
> > 
> > This sentence has the problem I described earlier today.
> 
> Fixed.
> --- ffmpeg.orig/libavcodec/bitstream.h	2009-04-11 15:45:50.000000000 +0200
> +++ ffmpeg/libavcodec/bitstream.h	2009-04-11 15:53:03.000000000 +0200
> @@ -159,6 +159,13 @@
> +
> +/**
> + * Puts the string \p s in the bitstream.
> + *
> + * @param put_zero if it is different from zero puts a '\0' char in
> + * the bitstream just after the end of the string

'\0'-terminate the string if value is non-zero

put_zero is not a very good name.

Diego



More information about the ffmpeg-devel mailing list