[FFmpeg-devel] [PATCH] Document ff_put_string()

Michael Niedermayer michaelni
Sat Apr 11 19:23:53 CEST 2009


On Sat, Apr 11, 2009 at 10:16:57AM -0700, Mike Melanson wrote:
> Michael Niedermayer wrote:
>> On Sat, Apr 11, 2009 at 06:00:51PM +0200, Stefano Sabatini wrote:
>>> On date Saturday 2009-04-11 16:11:36 +0200, Michael Niedermayer encoded:
>>>> On Sat, Apr 11, 2009 at 03:57:37PM +0200, Diego Biurrun wrote:
>>> [...]
>>>>> '\0'-terminate the string if value is non-zero
>>>> iam still unhappy
>>>> what about
>>>>
>>>> 0-terminate the written string if set
>>> Updated patch.
>>>
>>> I prefer "value is non-zero" since the phrase "value is
>>> set" is ambiguous.
>> than say "value is 1"
>
> But the value could be 2, or any other non-zero integer. Hence, "...if 
> value is non-zero".

1   -> write terminating zero
0   -> dont write terminating zero
rest-> undefined

reason, its easier to extend later

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090411/2f044e7d/attachment.pgp>



More information about the ffmpeg-devel mailing list