[FFmpeg-devel] [PATCH] remove x86 optimizations for Snow

[Diego Biurrun]

On Mon, Apr 13, 2009 at 03:02:16PM +0200, Michael Niedermayer wrote:
> On Mon, Apr 13, 2009 at 02:37:47PM +0200, Diego Biurrun wrote:
> > On Mon, Apr 13, 2009 at 02:31:51PM +0200, Michael Niedermayer wrote:
> > > On Mon, Apr 13, 2009 at 10:10:54AM +0200, Diego Biurrun wrote:
> > > > On Mon, Apr 13, 2009 at 02:05:32AM +0200, Michael Niedermayer wrote:
> > > > > On Mon, Apr 13, 2009 at 12:22:30AM +0200, Diego Biurrun wrote:
> > > > > > Here is a patch to remove x86 optimizations for Snow, similar to what I
> > > > > > just did for PPC.
> > > > > 
> > > > > rejected
> > > > 
> > > > Why?
> > > 
> > > Because this change does not simplify snow.
> > > And simplification is what should help people working on snow
> > > 
> > > also snow maybe should be forked to a fast vs. clean one
> > > 
> > > anyway, what should be reverted is the intermingling of MC and wavelet
> > > as well as the sliced wavelet stuff ...
> > 
> > Would that not entail removing the x86 optimizations?
> 
> maybe
> 
> >  If yes, why not remove them now?
> 
> because theres no point now, the patch wont rot, it still can be applied
> when it becomes needed

What's the point of keeping this useless code around?

> > > i think ive posted the svn revisions before, but reverting them may not
> > > be trivial now
> > 
> > Probably.  How hard would it be for you?
> 
> How hard would it be for the one who added them?

Who did?

Diego