[FFmpeg-devel] [PATCH] [RFC] Second try at pixdesc.h:write_line()

Stefano Sabatini stefano.sabatini-lala
Tue Apr 14 00:29:37 CEST 2009


Hi all,

the attached patchset is an attempt at solving the bitstream
randomization problem occurring when using skip_put_bits() and
flush_put_bits().

Since the write_line() function has to keep intact the skipped
content, I implemented the functions put_bits_save() and
skip_put_bits_safe().

No support is provided for BITSTREAM_WRITER_LE (and I see no way to
support that, and IMO no reason), and ALT_BITSTREAM_WRITER
corresponding functionality has to be implemented too.

For what regards the ALT_BITSTREAM_WRITER I think this shouldn't be
blocking, since for what I can see in skip_put_bytes() it is yet
non-functional.

Note that the randomization problem cannot be showed using the
pixdesc_test/hflip lavfi filters with the currently supported
bitstream pixel formats.

Regards.
-- 
FFmpeg = Foolish & Fundamentalist Mega Pitiless Elected Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bs-implement-put-bit-save.patch
Type: text/x-diff
Size: 873 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090414/a550b3e0/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bs-implement-skip-put-bits-safe.patch
Type: text/x-diff
Size: 976 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090414/a550b3e0/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pixdesc-write-line.patch
Type: text/x-diff
Size: 2489 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090414/a550b3e0/attachment-0002.patch>



More information about the ffmpeg-devel mailing list