[FFmpeg-devel] [PATCH][RFC] nsv seeking

[Jai Menon]

On 4/16/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Apr 15, 2009 at 09:16:59PM +0530, Jai Menon wrote:
>  > On Wed, Apr 15, 2009 at 5:29 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>  > > On Wed, Apr 15, 2009 at 10:03:22AM +0530, Jai Menon wrote:
>  > >> On 4/15/09, Michael Niedermayer <michaelni at gmx.at> wrote:
>  > >> > On Tue, Apr 14, 2009 at 10:22:56PM +0530, Jai Menon wrote:
>  > >> >  > On 3/20/09, Michael Niedermayer <michaelni at gmx.at> wrote:
>  > >> >  > > On Mon, Mar 16, 2009 at 12:15:27PM +0530, Jai Menon wrote:
>  > >>
>  > >> [...]
>  > >>
>  > >> >  > @@ -453,6 +465,16 @@ static int nsv_parse_NSVs_header(AVFormatContext *s, AVFormatParameters *ap)
>  > >> >
>  > >> > >              av_set_pts_info(st, 64, framerate.den, framerate.num);
>  > >> >  >              st->start_time = 0;
>  > >> >  >              st->duration = av_rescale(nsv->duration, framerate.num, 1000*framerate.den);
>  > >> >  > +
>  > >> >  > +            for(i=0;i<nsv->index_entries;i++) {
>  > >> >  > +                if(nsv->extended_index_data) {
>  > >> >  > +                    av_add_index_entry(st, nsv->nsvf_index_data[i], nsv->extended_index_data[i],
>  > >> >
>  > >> >
>  > >> > i think nsvf_index_data and extended_index_data are poor names
>  > >>
>  > >> Any suggestions? I could send a separate patch for nsvf_index_data.
>  > >> I named it extended_index_data because this is what the spec calls it.
>  > >
>  > > what does it contain?
>  >
>  > no. of frames before the frame at corresponding file offset (looked up
>  > from index_data)
>
>
> aka timestamp?

Yeah, you could say that.

>  so there are a
>  file_pos and a
>  timestamp
>  table ?

Yes, but only for toc2 style index. The old (deprecated)
not-so-precise style computes timestamps based on duration and no. of
entries in the index table. You can find the spec at
http://ultravox.aol.com/NSVFormat.rtf , maybe I'm misinterpreting
something.

>  > >> >  nsvf is in a nsv file demuxer redundant
>  > >> >  index_data is a little generic, is it time? file position?  ...
>  > >>
>  > >> index_data is the file offset.
>  > >
>  > > so file offset should be in the name
>  >
>  > Okay, i'll send a separate patch for that. Is that acceptable?
>
>
> yes

Patch for that posted separately.

-- 
Regards,

Jai