[FFmpeg-devel] [PATCH] Implement function to compute bits per pixel

Stefano Sabatini stefano.sabatini-lala
Mon Apr 27 23:39:58 CEST 2009


On date Monday 2009-04-27 14:40:42 +0200, Michael Niedermayer encoded:
> On Mon, Apr 27, 2009 at 02:16:15PM +0200, Michael Niedermayer wrote:
> > On Sun, Apr 26, 2009 at 03:15:24PM +0200, Stefano Sabatini wrote:
> 
> [...]
> > [...]
> > > Index: libavfilter-soc/ffmpeg/libavcodec/pixdesc.h
> > > ===================================================================
> > > --- libavfilter-soc.orig/ffmpeg/libavcodec/pixdesc.h	2009-04-26 11:30:27.000000000 +0200
> > > +++ libavfilter-soc/ffmpeg/libavcodec/pixdesc.h	2009-04-26 12:15:37.000000000 +0200
> > > @@ -193,4 +193,10 @@
> > >      }
> > >  }
> > >  
> > > +/**
> > > + * Returns the number of bits per pixel used by the pixel format
> > > + * described by pixdesc.
> > > + */
> > > +int av_pixdesc_get_bits_per_pixel(const AVPixFmtDescriptor *pixdesc);
> > 
> > av_get_bits_per_pixel
> > or
> > av_bits_per_pixel
> > 
> > seem better names
> 
> The correct name that fits best in the current naming is
> av_get_bits_per_pixel(), please use this

Check again.

Should I keep the test program when committing?

Regards.
-- 
FFmpeg = Fundamental & Faboulous MultiPurpose Ecstatic Gargoyle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pixdesc-get-bpp.patch
Type: text/x-diff
Size: 1693 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090427/34fb64b6/attachment.patch>



More information about the ffmpeg-devel mailing list