[FFmpeg-devel] [PATCH] Psygnosis YOP demuxer

[Thomas Higdon]

On Sat, Aug 8, 2009 at 11:21 PM, Mike Melanson<mike at multimedia.cx> wrote:
> Thomas Higdon wrote:
>>
>> On Sat, Aug 8, 2009 at 7:10 PM, Thomas Higdon<thomas.p.higdon at gmail.com>
>> wrote:
>>>
>>> Also, I believe there still may be problems with this demuxer. When
>>> the stream ends, the video freezes, and A-V sync continues into the
>>> negative indefinitely. Any ideas on what might be causing this?
>>
>> Further investigation reveals that this happens with some other clips
>> I tried, so perhaps it's just a bug in ffplay.
>
> Does FFmpeg work? (E.g., 'ffmpeg -i file.yop %04d.png' should decode the
> frames to a series of PNG files and exit cleanly.)

As a matter of fact, it didn't (it continued decoding frames
indefinitely). I've fixed it by returning AVERROR(EIO) in the event
that an av_get_packet() returns with a size less than I asked for in
yop_read_packet().

I'm able to successfully transcode the sample files to tiff, png, avi
mpeg4, and rv10 using ffmpeg, which now exits cleanly at the end of
the stream (although ffplay still doesn't exit at the end of the
stream). I've also run a test file through tools/trasher several
times, and had no crashes using either ffplay or ffmpeg. I've run
ffmpeg using my YOP demuxer and decoder through valgrind with no leaks
or errors. Any other suggestions for verification?

The updated demuxer patch is attached. Should I post the decoder, or
wait to see if the demuxer is approved?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yop-demux.diff
Type: text/x-patch
Size: 8355 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/395c342d/attachment.bin>