[FFmpeg-devel] [PATCH] more APE optimization

Vitor Sessak vitor1001
Fri Dec 4 18:12:27 CET 2009


Robert Swain wrote:
> On Fri, 2009-12-04 at 15:19 +0000, Loren Merritt wrote:
>> After applying this, there is only one reference to scalarproduct_int16(), 
>> in acelp_pitch_delay.c. AFAICT, acelp_pitch_delay.c hasn't ever been 
>> compiled. Is it someone's work-in-progress, or can I delete 
>> scalarproduct_int16?
> 
> It may be something Vitor is working on. He's been factoring out common
> code from a number of ACELP codecs including ones not yet in trunk. It
> would probably be a good idea to ask him.

It was used by both G.729 and fixed-point SIPR code. Both are unfinished 
and not been worked on ATM (I'm working on a _float_ SIPR decoder).

Besides that, in one hand a optimized int16 scalar product looks useful 
to me no matter what, but in the other hand it has already a known bug 
(issue1193)...

-Vitor



More information about the ffmpeg-devel mailing list