[FFmpeg-devel] [PATCH 2/2] Add SIPR decoder for 5k0, 6k5 and 8k5 modes

[Diego Biurrun]

On Fri, Dec 18, 2009 at 05:52:13PM +0100, Vitor Sessak wrote:
>
> --- libavcodec/sipr.c	(revision 0)
> +++ libavcodec/sipr.c	(revision 0)
> @@ -0,0 +1,611 @@
> +typedef struct
> +{

{ on the same line

> +            ff_celp_lp_synthesis_filterf(
> +                ctx->postfilter_syn5k0 + LP_FILTER_ORDER + i*subsize,
> +                pAz, excitation, L_SUBFR_SIPR, LP_FILTER_ORDER);

ugly formatting

> +            float energy = ff_dot_productf(
> +                ctx->postfilter_syn5k0 + LP_FILTER_ORDER + i * subsize,
> +                ctx->postfilter_syn5k0 + LP_FILTER_ORDER + i * subsize,
> +                L_SUBFR_SIPR);

again

> +    ff_acelp_apply_order_2_transfer_function(
> +        synth,
> +        (const float[2])  {-1.99997   , 1.},
> +        (const float[2])  {-1.93307352, 0.935891986},
> +        0.939805806, ctx->ymem, frame_size);

ditto

> +AVCodec sipr_decoder =
> +{

{ on the same line

> --- libavcodec/siprdata.h	(revision 0)
> +++ libavcodec/siprdata.h	(revision 0)
> @@ -0,0 +1,271 @@
> +
> +#ifndef FFMPEG_SIPRDATA_H
> +#define FFMPEG_SIPRDATA_H

AVCODEC_

> +#endif // FFMPEG_SIPRDATA_H

Please use /* */ here for consistency.

> --- libavcodec/Makefile	(revision 20893)
> +++ libavcodec/Makefile	(working copy)
> @@ -271,6 +271,7 @@
>  OBJS-$(CONFIG_SHORTEN_DECODER)         += shorten.o
> +OBJS-$(CONFIG_SIPR_DECODER)            += sipr.o acelp_pitch_delay.o celp_math.o acelp_vectors.o acelp_filters.o celp_filters.o lsp.o

Please break this long line.

Diego