[FFmpeg-devel] [PATCH] Implement -sample_fmts

[Stefano Sabatini]

On date Monday 2009-12-21 23:43:05 +0100, Michael Niedermayer encoded:
> On Mon, Dec 21, 2009 at 11:11:30PM +0100, Stefano Sabatini wrote:
> > Hi,
> > similar to -pix_fmts.
> > -- 
> > FFmpeg = Faboulous and Friendly Mournful Puritan Eager Governor
> 
> >  cmdutils.c                   |    6 ++++++
> >  cmdutils.h                   |    6 ++++++
> >  cmdutils_common_opts.h       |    1 +
> >  doc/fftools-common-opts.texi |    3 +++
> >  4 files changed, 16 insertions(+)
> > bd7d7f8721f2cc7a910d52e1d40493246eae3881  implement-sample-fmts.patch
> 
> we already have -sample_fmt list, so this is not needed

1) the same should be applied to -pix_fmts, on the other hand for
example ffplay has a -pix_fmt option but in that case -pix_fmt list is
not implemented.

2) there are already many options showing elements, -codecs, -formats,
-pix_fmts etc. so the user may expect to find a similar thing for
sample formats.

3) -sample_fmt list is weird syntax/beavior, -key VERB when the user
may expect -key VALUE (BTW this is also one of the reason for which I
would have preferred -list STUFF), so my suggestion is to remove
-sample_fmt/-pix_fmt list instead.

Regards.
-- 
FFmpeg = Friendly Faboulous Miracolous Portentous Educated Gangster