[FFmpeg-devel] [PATCH][VAAPI][6/6] Add H.264 bitstream decoding (take 20)

[Michael Niedermayer]

On Sun, Dec 27, 2009 at 11:58:27PM +0100, Gwenole Beauchesne wrote:
> Hi,
>
> Le 27 d?c. 09 ? 22:46, Michael Niedermayer a ?crit :
>
>>> +    va_pic->picture_id = ff_vaapi_get_surface(pic);
>>
>> i think it should be called ff_vaapi_get_surface_id()
>
> Would a separate patch that s/ff_vaapi_get_surface/ff_vaapi_get_surface_id/ 
> existing vaapi*.[ch] be OK?

yes just apply such change


>
>>> +    /* Fill in VAPictureParameterBufferH264. */
>>> +    pic_param = ff_vaapi_alloc_picture(vactx, 
>>> sizeof(VAPictureParameterBufferH264));
>>
>> we have a VAPictureH264 and a VAPictureParameterBufferH264
>> a function called ff_vaapi_alloc_picture() is not named appropriately to
>> allocate a Parameter Buffer
>
> Would a separate patch that 
> s/ff_vaapi_alloc_picture/ff_vaapi_alloc_pic_param/ existing vaapi*.[ch] be 
> OK?

yes just apply such change

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091228/642daa22/attachment.pgp>