[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Mohamed Naufal]

2009/12/31 Reimar D?ffinger <Reimar.Doeffinger at gmx.de>

> On Thu, Dec 31, 2009 at 05:02:34PM +0530, Mohamed Naufal wrote:
> > 2009/12/31 Reimar D?ffinger <Reimar.Doeffinger at gmx.de>
> >
>


[...]


> Add
> .flags = AVFMT_GENERIC_INDEX,
> to yop_demuxer, test seeking (e.g. with ffplay).
> It should only work reliable if you set pkt.pos to a file position from
> which your demuxer can start (i.e. the start of the palette data).
>


 Done.



> > +    if (yop->video_packet.data) {
> > +        *pkt = yop->video_packet;
> > +        yop->video_packet.data = NULL;
> > +        yop->video_packet.size = 0;
>
> I'm undecided if this is better or (mis?-)using destruct_nofree.
>


I thought av_destruct_packet_nofree() was deprecated. Changed back.

[...]



> And here you forgot the free.
> I was quite serious when is suggested to use "goto err_out" to handle
> the freeing in one single place, if you don't you _will_ have memleaks,
> I have seen it often enough.
>


Implemented goto.

[...]

Also fixed other issues.

Naufal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yop_demux.patch
Type: text/x-patch
Size: 7826 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091231/cbb91976/attachment.bin>