[FFmpeg-devel] [PATCH] Make RM demuxer behave better with -an option

Michael Niedermayer michaelni
Mon Feb 2 19:47:22 CET 2009


On Mon, Feb 02, 2009 at 01:37:12PM -0500, Ronald S. Bultje wrote:
> On Mon, Feb 2, 2009 at 2:19 PM, Kostya <kostya.shishkov at gmail.com> wrote:
> > The story so far:
> >  FFmpeg now has RV30, RV40 (my fault) and AAC (not my fault) support. When
> > trying to decode RV40+AAC RM file with -an option video decoder produces
> > a lot of garbage and may crash. As I've investigated, that happens because
> > with -an option specified RM demuxer begins to feed audio packets to video
> > decoder.
> 
> My personal opinion is that that piece of code is dirty anyway
> (ff_rm_parse_packet() for AAC doesn't read the complete RM packet, but
> just one AAC frame), whereas for others (ATRAC3, cook, etc.) it reads
> the multiple packets and stores them in ast->buf. Maybe for AAC, it
> should do that also. That also allows to get rid of the special case
> in ff_rm_retrieve_cache().

do you want to cleanup & simplify the rm demuxer? :)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090202/128a2fba/attachment.pgp>



More information about the ffmpeg-devel mailing list