[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

[Michael Niedermayer]

On Mon, Feb 02, 2009 at 10:58:29PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Feb 2, 2009 at 4:17 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Jan 31, 2009 at 10:26:30PM -0500, Ronald S. Bultje wrote:
> >> +void ff_wms_parse_sdp_a_line(AVFormatContext *s, const char *p)
> >> +{
> >> +    if (av_strstart(p, "pgmpu:data:application/vnd.ms.wms-hdr.asfv1;base64,", &p)) {
> >> +        ByteIOContext gb;
> > [...]
> >> +        rt->asf_ctx->pb = NULL;
> >
> > gb or pb ?
> >
> >> +    /** Windows Media-specific entries */
> >> +    AVFormatContext *asf_ctx;
> >
> > This explanation is unsatisfying, it doesnt awnser what that variable is/means
> 
> Both fixed in $attached.
[...]
> Index: ffmpeg-svn/libavformat/rtsp.h
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/rtsp.h	2009-02-01 08:18:04.000000000 -0500
> +++ ffmpeg-svn/libavformat/rtsp.h	2009-02-02 22:57:06.000000000 -0500
> @@ -108,6 +108,9 @@
>      int need_subscription;
>      enum AVDiscard real_setup_cache[MAX_STREAMS];
>      char last_subscription[1024];
> +
> +    /** ASF demuxer context for the embedded ASF stream from WMS servers */
> +    AVFormatContext *asf_ctx;
>  } RTSPState;

why is rm/rdt and asf using different things?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090203/77fb087a/attachment.pgp>