[FFmpeg-devel] [PATCH] MTH demuxer (Gamecube format)

[Diego Biurrun]

On Tue, Feb 03, 2009 at 12:06:04PM -0500, Michael Montanye wrote:
> I was hoping to find a second game to sample, but my small collection  
> only gave me one game that used these.

Changelog update missing..

> --- libavformat/mth.c	(revision 0)
> +++ libavformat/mth.c	(revision 0)
> @@ -0,0 +1,134 @@
> +/*
> + * MTHP Demuxer

MTHP?

Lowercase "demuxer".

> +    av_set_pts_info(st, 64, 1, mth->fps);
> +    st->codec->codec_type = CODEC_TYPE_VIDEO;
> +    st->codec->codec_id = CODEC_ID_THP;
> +    st->codec->codec_tag = 0;  /* no fourcc */
> +    st->codec->width = mth->width;
> +    st->codec->height = mth->height;
> +    st->codec->sample_rate = av_q2d(mth->framerate);
> +    mth->vst = st;
> +    mth->video_stream_index = st->index;

This could be aligned.

> +static int mth_read_packet(AVFormatContext *s,
> +                            AVPacket *pkt)

One space too much, but you can just merge the lines.

> +    /* Locate the next frame and read out its size.  */
> +    mth->next_frame += mth->next_framesz;
> +    mth->next_framesz = get_be32(pb);

align

Diego