[FFmpeg-devel] [PATCH] MTH demuxer (Gamecube format)

[Jai Menon]

Hi,

On Fri, Feb 6, 2009 at 11:35 AM, Michael Montanye
<montanye at myfairpoint.net> wrote:
> Mike Melanson wrote:
>>
>> Diego Biurrun wrote:
>>
>>>
>>> On Thu, Feb 05, 2009 at 10:12:52AM +0100, Marc Mason wrote:
>>>
>>>>
>>>> Diego Biurrun wrote:
>>>>
>>>>
>>>>>
>>>>> Mike Melanson wrote:
>>>>>
>>>>>
>>>>>>
>>>>>> I decided to go with the file signature instead.
>>>>>>
>>>>>
>>>>> What do you mean by signature?
>>>>>
>>>>
>>>> Perhaps he meant
>>>>
>>>> http://en.wikipedia.org/wiki/File_format#Magic_number
>>>>
>>>> http://en.wikipedia.org/wiki/Magic_number_(programming)#Magic_numbers_in_files
>>>>
>>>
>>> I was basically wondering why it is called MTH in one place and MTHP in
>>> another.  IMO we should use only one description, otherwise we will only
>>> generate confusion.  DV is not the same as DVD or DVB.
>>>
>>
>> I vote for MTHP as the consistent term. As mentioned, it's the file's
>> signature and thus the most consistent identifier. MTH is just to accomodate
>> the common convention of the 3-letter file extensions. This is consistent
>> with our reasoning for referring to MPEG rather than MPG.
>>
>>
>
> That makes sense, especially since I just found a GC game that uses no file
> extensions at all, and the only way to find the FMVs was to look at the
> signature.  And it's trivial to change.  Changed, new patch attached.
>
> -Michael Montanye
>
> Index: Changelog
> ===================================================================
> --- Changelog   (revision 16909)
> +++ Changelog   (working copy)
> @@ -146,6 +146,7 @@
>  - hybrid WavPack support
>  - R3D REDCODE demuxer
>  - ALSA support for playback and record
> +- MTHP demuxer

Just a heads up, this won't apply to svn head. svn up and regenerate.

[...]

-- 
Regards,

Jai