[FFmpeg-devel] [PATCH] convert to S16 when resampling is requested

[Diego Biurrun]

On Sun, Feb 08, 2009 at 05:16:53PM -0800, Baptiste Coudurier wrote:
> Baptiste Coudurier wrote:
> > [...]
> >
> > +/**
> > + *  Initialize audio resampling context

I think Michael prefers javadoc-style third person singular, i.e.

  Initializes audio resampling context.

> > + * @param output_channels number of output channels
> > + * @param input_channels  number of input channels
> > + * @param output_rate     output sample rate
> > + * @param input_rate      input sample rate

fine

> > + * @param sample_fmt_out  wanted output sample format

requested output sample format

> > + * @param sample_fmt_in   input sample format
> > + * @return allocated ReSampleContext, NULL if error occured

fine

> Forgot to ask, can you please give me a good doxygen description for
> other params ? Would be great.

The description is OK IMO.  Or were you asking about something else?

Diego