[FFmpeg-devel] Process (Was: [PATCH][7/8] Add VA API accelerated H.264 decoding (take 4))

[Michael Niedermayer]

On Tue, Feb 10, 2009 at 12:12:31PM +0100, Michael Niedermayer wrote:
> On Tue, Feb 10, 2009 at 11:18:08AM +0100, Gwenole Beauchesne wrote:
[...]
> > Otherwise, I already saw reactions like: "the code has your 
> > answers, if you bother" ; "if you can't read any code, you are a beginner 
> > programmer", etc. That's also has a psychological effect, some people like 
> > bitching at others easily and newcomers would like to avoid that. IOW, in 
> > order to keep one's mental health sane, it's better not attempt things 
> > that would get those usual reactions. => base your code off current 
> > practise.
> > 
> 
> > Now, you could also warn people that: "be careful, FFmpeg code is probably 
> > architecturally broken, don't assume anything! Come and discuss first, we 
> 
> what may be acceptable as interface to one API may not be for more than 1
> besides you didnt expect a program of the size of ffmpeg to be without bugs
> and suboptimal parts did you?
> 
> 
> > do promise we won't bite you. If we do, OK, if we would accept your patch 
> > wihout compromise. ;-)".
> > 
> 
> > > if so why do you belive i knew more when even the author of the patch 
> > > apparently didnt notice every problem.
> > 
> > Because you are actually the one who know more the surrounding code and 
> > has the best overview of the code. So, you are a reference, if you 
> > accepted a patch, then it was a correct practise and incentive to others 
> > to operate the same.
> 
> humans make mistakes, we should learn out of them not not repeat them
> you ask me to repeat my mistake and accept your patch with the same issues
> as previous ones.

but actually accepting the first API (VDPAU) wasnt that much of a mistake,
its the second similar API (XVMC isnt that similar) that raises the need
for factorization

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090210/8b7f3f9b/attachment.pgp>