[FFmpeg-devel] [PATCH] fix heap corruption when resampling 8-bit audio

Peter Ross pross
Sat Feb 14 00:42:05 CET 2009


r17163 added the 'convert to s16' logic within audio_resample().
This works as expected when resampling from a >16-bit audio source,
but crashes when resampling from an 8-bit audio source. The
size of the intermediate 16-bit buffer is presently calculated
using the input sample size, and this varies depending on the input.
This is wrong, as the intermediate buffer is expected to store
16-bit samples.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: resample-cvt16-overflow.diff
Type: text/x-diff
Size: 555 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090214/8a969313/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090214/8a969313/attachment.pgp>



More information about the ffmpeg-devel mailing list