[FFmpeg-devel] [PATCH] rtsp.[ch]: RTSPHeader -> RTSPServerResponse [was: [PATCH] document rtsp.h]

Ronald S. Bultje rsbultje
Sat Feb 21 21:53:52 CET 2009


Hi Luca,

On Sat, Feb 21, 2009 at 3:33 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
> Ronald S. Bultje wrote:
>> On Sat, Feb 21, 2009 at 10:19 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
>>> Ronald S. Bultje wrote:
>>>> 2009/2/18 Michael Niedermayer <michaelni at gmx.at>:
>>>>> iam not maintainer of any of the affected files ...
>>>> OK, new subject then, patch re-attached for general review.
>>> Why this change? A ClientResponse would have different fields?
>>
>> RTSPHeader is a vague term. I proposed RTSPServerResponse because
>> that's how it's used in the code, but you're right, a client-res would
>> be the same. What about RTSPCmdResponse?
>
> If you want to be absolutely clear I'd Use RTSPMessageHeader since it's
> in line with the rfc definitions, but there isn't much to be confused
> about it.

Ok, I'll change it to that. Michael is that OK with you?

I have to change it or else Michael won't let me commit the RTP/ASF stuff. :-).

Ronald




More information about the ffmpeg-devel mailing list