[FFmpeg-devel] [PATCH] Workaround Mac-OS x86_64 dynamic loader bug for Yasm generated code

Loren Merritt lorenm
Sun Feb 22 02:04:35 CET 2009


On Sat, 14 Feb 2009, Art Clarke wrote:

> On Wed, Feb 4, 2009 at 12:53 PM, Art Clarke <aclarke at xuggle.com> wrote:
>> On Wed, Feb 4, 2009 at 12:27 PM, Art Clarke <aclarke at xuggle.com> wrote:
>>> See this chain for details on the problem:
>>> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-February/061189.html
>>>
>>> Tested on Mac and Linux in 32 and 64 bit builds and everything seems to work.
>
> Index: libavcodec/x86/fft_mmx.asm
> ===================================================================
> --- libavcodec/x86/fft_mmx.asm	(revision 16989)
> +++ libavcodec/x86/fft_mmx.asm	(working copy)
> @@ -446,8 +446,16 @@
> %endrep
> %undef n
>
> +%ifidn __OUTPUT_FORMAT__,macho64
> +; Putting this section in .text on x86_64 darwin causes problems
> +section .rodata align=16
> +%endif
> align 8
> dispatch_tab%3%2: pointer list_of_fft
> +%ifidn __OUTPUT_FORMAT__,macho64
> +; Set section back to .text
> +section .text align=16
> +%endif

I'm confused. Wasn't this patch already applied in r17197, 28 hours before 
Art's ping?

--Loren Merritt




More information about the ffmpeg-devel mailing list