[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

Kostya kostya.shishkov
Sun Feb 22 13:07:35 CET 2009


On Sun, Feb 22, 2009 at 11:56:56AM +0100, Diego Biurrun wrote:
> On Sun, Feb 22, 2009 at 11:50:50AM +0100, Diego Biurrun wrote:
> > On Sun, Feb 22, 2009 at 12:20:16PM +0200, Kostya wrote:
> > > On Thu, Feb 12, 2009 at 11:40:59PM +0100, Michael Niedermayer wrote:
> > > > On Thu, Feb 12, 2009 at 10:26:21AM +0200, Kostya wrote:
> > > [...]
> > > > > > maybe a few const could be added?
> > > > > > 
> > > > > > ok except these
> > > > > 
> > > > > Since it's not wholly identical with the old one, regressions are changed too.
> > > > > Attached an example of mine obtained at PPC.
> > > > 
> > > > the regression change looks harmless after a quick look ...
> > > 
> > > I took the liberty to apply it after all.
> > 
> > yuv2rgb.c is not compiled but still around.  IMO you should just have
> > replaced one file with the other and not add a new one with a 2 suffix.
> 
> It's also unclear what needs to be changed in configure, README, etc...

I've committed everything related:
libswscale <- actual change
ffmpeg     <- regression checksums changes
mplayer    <- changelog (why leave this repo aside?)

As for making it usable in LGPL I've done this locally (sorry, no patch):
* removed --enable-swscale and its GPL dependency from configure
* added swscale to the list of always compiled libs in all Makefiles
* removed libavcodec/imgresample.c and one hunk for CONFIG_OLDSCALER from
 libavcodec/imgconvert.c

> Diego




More information about the ffmpeg-devel mailing list