[FFmpeg-devel] [RFC][PATCH] ticks_per_frame / timebase

[Baptiste Coudurier]

Hi guys,

Michael Niedermayer wrote:
> On Thu, Feb 26, 2009 at 10:05:28PM +0100, Ivan Schreter wrote:
>> Michael Niedermayer wrote:
>>> [...]
>>> also i think the reset of the sei vars should be in
>>> decode_nal_units()
>>> ...
>>>     if(!(s->flags2 & CODEC_FLAG2_CHUNKS)){
>>>         h->current_slice = 0;
>>>         if (!s->first_field)
>>>             s->current_picture_ptr= NULL;
>>>         <-----------------------here
>>>     }
>>>
>>> the reason is that just reseting at the end of a pic is "risky" if that 
>>> end
>>> isnt reached
>>>
>>>   
>> Like in the attached patch?
> 
> yes, patch ok
> 
> btw, if you want a svn write account, (and agree to the devel/svn policy
> and split patches a little more, this one should be
> factorizing the code and then seperately adding the new call)
> then send diego b. some username & password gpg encrypted
> 

Applied both patches:

ffmpeg -i h264.mp4 -vcodec copy test.mov

Seems stream 1 codec frame rate differs from container frame rate: 12.50
(25/2) -> 25.00 (25/1)
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'H264.mp4':
  Duration: 00:00:02.18, start: 0.000000, bitrate: 2245 kb/s
    Stream #0.0(eng): Audio: aac, 44100 Hz, stereo, s16
    Stream #0.1(eng): Video: h264, yuv420p, 720x576, 25 tbr, 25 tbn, 25 tbc
File 'test.mov' already exists. Overwrite ? [y/N] y
Output #0, mov, to 'test.mov':
    Stream #0.0(eng): Video: libx264, yuv420p, 720x576, q=2-31, 90k tbn,
25 tbc
    Stream #0.1(eng): Audio: libfaac, 44100 Hz, stereo, s16, 64 kb/s

Is this supposed to report 12.50 ?

Also in h.264 in flv:

Seems stream 0 codec frame rate differs from container frame rate: 23.98
(48000/2002) -> 44.42 (533/12)
Input #0, flv, from 'h264_acc_in_flv.flv':
  Duration: 00:01:07.51, start: 0.105000, bitrate: N/A
    Stream #0.0: Video: h264, yuv420p, 640x480 [PAR 1:1 DAR 4:3], 44.42
tbr, 1k tbn, 47.95 tbc
    Stream #0.1: Audio: aac, 48000 Hz, stereo, s16
At least one output file must be specified

Before:

Input #0, flv, from 'h264_acc_in_flv.flv':
  Duration: 00:01:07.51, start: 0.105000, bitrate: N/A
    Stream #0.0: Video: h264, yuv420p, 640x480 [PAR 1:1 DAR 4:3], 23.98
fps(r)
    Stream #0.1: Audio: libfaad, 48000 Hz, stereo, s16
Must supply at least one output file


I tried setting need_parsing to AVSTREAM_PARSER_HEADERS, did not change
anything.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org