[FFmpeg-devel] [PATCH] Integrate avfiltergraph.[ch] and graphparser.[ch]

Stefano Sabatini stefano.sabatini-lala
Fri Feb 27 01:34:37 CET 2009


On date Friday 2009-02-27 01:05:21 +0100, Michael Niedermayer encoded:
> On Thu, Feb 26, 2009 at 11:18:41PM +0100, Stefano Sabatini wrote:
> > On date Thursday 2009-02-26 22:39:29 +0100, Michael Niedermayer encoded:
> > > On Thu, Feb 26, 2009 at 09:16:42PM +0100, Stefano Sabatini wrote:
> > > > Hi all,
> > > > 
> > > > avfiltergraph and graphparser are not still exported to the public
> > > > though they are in SVN, I realized this too late since I upgraded
> > > > minor more than once.
> > > > 
> > > > Now reviewing the headers I found that the names are all nice and
> > > > consistent, but two for which I propose the renames:
> > > > 
> > > 
> > > 
> > > > avfilter_destroy_graph -> avfilter_graph_destroy
> > > > and
> > > > avfilter_parse_graph   -> avfilter_graph_parse
> > > 
> > > ok
> > 
> > Applied.
> >  
> > > > The functions are not still public, so no need to update versions,
> > > > afterwards I propose to apply the attached patches.
> > > 
> > > like has been said a big fat warning is needed first
> > 
> > Agree, please check it again, alternatively we could simply not to
> > export the API for the moment, but simply include it in the lib
> > object.
> 
> ok if the headers are needed by ffmpeg/ffplay

Do you mean *after* lavfi integration? Yes both of them parse a graph
description and so they need graphparser.h (which includes
avfiltergraph.h).

Regards.
-- 
FFmpeg = Faboulous and Faithful Merciless Ponderous Enlightening Guru




More information about the ffmpeg-devel mailing list