[FFmpeg-devel] [PATCH][VAAPI][1/6] Add VA API formats (take 2)

[Gwenole Beauchesne]

On Fri, 27 Feb 2009, Michael Niedermayer wrote:

>> @@ -419,6 +419,20 @@ static const PixFmtInfo pix_fmt_info[PIX_FMT_NB] = {
>>          .depth = 8,
>>          .x_chroma_shift = 0, .y_chroma_shift = 0,
>>      },
>> +
>> +    /* VA API formats */
>> +    [PIX_FMT_VAAPI_MOCO] = {
>> +        .name = "vaapi_moco",
>> +        .is_hwaccel = 1,
>> +    },
>> +    [PIX_FMT_VAAPI_IDCT] = {
>> +        .name = "vaapi_idct",
>> +        .is_hwaccel = 1,
>> +    },
>> +    [PIX_FMT_VAAPI_VLD] = {
>> +        .name = "vaapi_vld",
>> +        .is_hwaccel = 1,
>> +    },
>>  };
>
> these are missing the chroma sub sample values

.{x,y}_chroma_shift = 1?

> [off topic] also ff_print_debug_info() might be missing a if hw_accel return

At the top or only
-    if((s->avctx->debug&(FF_DEBUG_VIS_QP|FF_DEBUG_VIS_MB_TYPE)) || (s->avctx->debug_mv)){
+    if(!s->avctx->hwaccel && ((s->avctx->debug&(FF_DEBUG_VIS_QP|FF_DEBUG_VIS_MB_TYPE)) || (s->avctx->debug_mv))){
?