[FFmpeg-devel] [PATCH][VAAPI][1/6] Add VA API formats (take 2)

[Michael Niedermayer]

On Fri, Feb 27, 2009 at 01:28:17PM +0100, Gwenole Beauchesne wrote:
> On Fri, 27 Feb 2009, Michael Niedermayer wrote:
> 
> >> @@ -419,6 +419,20 @@ static const PixFmtInfo pix_fmt_info[PIX_FMT_NB] = {
> >>          .depth = 8,
> >>          .x_chroma_shift = 0, .y_chroma_shift = 0,
> >>      },
> >> +
> >> +    /* VA API formats */
> >> +    [PIX_FMT_VAAPI_MOCO] = {
> >> +        .name = "vaapi_moco",
> >> +        .is_hwaccel = 1,
> >> +    },
> >> +    [PIX_FMT_VAAPI_IDCT] = {
> >> +        .name = "vaapi_idct",
> >> +        .is_hwaccel = 1,
> >> +    },
> >> +    [PIX_FMT_VAAPI_VLD] = {
> >> +        .name = "vaapi_vld",
> >> +        .is_hwaccel = 1,
> >> +    },
> >>  };
> >
> > these are missing the chroma sub sample values
> 
> .{x,y}_chroma_shift = 1?

yes


> 
> > [off topic] also ff_print_debug_info() might be missing a if hw_accel return
> 
> At the top or only
> -    if((s->avctx->debug&(FF_DEBUG_VIS_QP|FF_DEBUG_VIS_MB_TYPE)) || (s->avctx->debug_mv)){
> +    if(!s->avctx->hwaccel && ((s->avctx->debug&(FF_DEBUG_VIS_QP|FF_DEBUG_VIS_MB_TYPE)) || (s->avctx->debug_mv))){
> ?

i think a seperate if()  would be prettier

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090227/f40aa793/attachment.pgp>