[FFmpeg-devel] [PATCH] --enable-libx264 and --enable-libxvid depend on --enable-pthread

[Måns Rullgård]

Peter Eszlari <peter.eszlari at googlemail.com> writes:

> 2009/2/27 M?ns Rullg?rd <mans at mansr.com>:
>> Peter Eszlari <peter.eszlari at googlemail.com> writes:
>>
>>> see $subj
>>>
>>> Index: configure
>>> ===================================================================
>>> --- configure (revision 17647)
>>> +++ configure (working copy)
>>> @@ -1687,6 +1687,16 @@
>>> ? ? ?die_gpl_disabled "The software scaler" ? ? swscale
>>> ?fi
>>>
>>> +if ! enabled pthreads; then
>>> + ? ?die_pthreads_disabled(){
>>> + ? ? ? ?name=$1
>>> + ? ? ? ?shift
>>> + ? ? ? ?enabled_any $@ && die "$name needs pthreads and --enable-pthreads is not specified."
>>> + ? ?}
>>> + ? ?die_pthreads_disabled "libx264" ? ? ? ? ? ? ? ? libx264
>>> + ? ?die_pthreads_disabled "libxvidcore" ? ? ? ? ? ? libxvid
>>> +fi
>>
>> That is not necessarily true.
>
> Is this better...?
>
> Index: configure
> ===================================================================
> --- configure	(revision 17647)
> +++ configure	(working copy)
> @@ -693,7 +693,7 @@
>      header="$2"
>      func="$3"
>      shift 3
> -    check_lib $header $func "$@" || die "ERROR: $name not found"
> +    check_lib $header $func "$@" || die "ERROR: $name not found (If x264/xvid is build with pthreads you must specify --enable-pthreads)" # needed when they are build statically
>  }

No, that will print the message on *any* failed check.

-- 
M?ns Rullg?rd
mans at mansr.com