[FFmpeg-devel] [PATCH] rtpdec.c: don't overwrite pkt->stream_index in finalize_packet()

Ronald S. Bultje rsbultje
Sat Feb 28 19:15:49 CET 2009


Hi Luca,

On Sat, Feb 28, 2009 at 2:03 PM, Luca Abeni <lucabe72 at email.it> wrote:
> Looking at your patch, I wonder on which tree it is based: AFAIK the
> current code only calls finalize_packet() for static payloads (yes, this
> is a bug and needs to be fixed).

Only for the first AVPacket in a RTP packet. The remainder is handled
by repeatedly calling rtp_parse_packet() with NULL/0 buf/size (handled
in the top part of rtp_parse_packet()), and then finalize_packet() is
called in all cases. And now that you mention it, I suppose this means
h264 isn't actually setting stream_index for the first buffer.

On that line, I suppose attached patch fixes the same issue and is in
fact much simpler.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dont-touch-st_id.patch
Type: application/octet-stream
Size: 1076 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090228/55e6c06e/attachment.obj>



More information about the ffmpeg-devel mailing list